refactor: webdav plugin #138
Merged
+20
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoaoSRaposo
approved these changes
May 30, 2025
Collaborator
JoaoSRaposo
left a comment
JoaoSRaposo
left a comment
There was a problem hiding this comment.
I tested the following features in the local development environment (NC 30):
Comments: ok
Tags: ok
Upload: ok.
Download: ok.
Archive Files and Folders: ok.
Unarchive Files and Folders: ok.
Rename files: ok
Rename folder: ok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors and simplifies the
WebDavPluginclass by streamlining visibility and file operation logic and improving exception handling. Key changes include consolidating redundant code blocks and ensuring proper namespacing for exceptions.Refactoring of file operation logic:
lib/Sabre/WebDavPlugin.php: Simplified thehttpPostmethod by consolidating redundant logic for handlingFileandDirectorynodes into shared code blocks. The visibility logic (hide/unhide) now uses a single conditional to set visibility, and thearchive,unarchive, andmoveactions have been streamlined for clarity.Improvements to exception handling:
lib/Sabre/WebDavPlugin.php: Updated thehttpMovemethod to use fully qualified namespacing for exceptions (\Exception) to ensure compatibility and clarity. Removed the redundantContent-Lengthheader setting in the response.